Torch dispatch for scipy-like functions and Softplus #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm okay with closing this, just want to get your thoughts on it in relation to #1065 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
==========================================
+ Coverage 81.95% 82.10% +0.15%
==========================================
Files 182 183 +1
Lines 47866 47933 +67
Branches 8622 8633 +11
==========================================
+ Hits 39228 39357 +129
+ Misses 6472 6410 -62
Partials 2166 2166
|
This looks fine why did you ask about closing it? Can you add some small tests for one of the scipy ops and the softplus? |
ricardoV94
changed the title
ricardoV94
reviewed
Nov 11, 2024
| @@ -4,6 +4,7 @@ | |||
| import numpy as np | |||
| import pytest | |||
|
|
|||
| import pytensor.tensor as pt | |||
There was a problem hiding this comment.
We prefer to use explicit imports as a policy. In your case import expit and softplus directly
ricardoV94
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was goofing around with pymc using the pytorch backend. I implemented a beta binomial model and had an issue when supporting some scipy methods, and was missing softplus. I wrote some small shims. Let me know your thoughts on the importlib stuff.
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1066.org.readthedocs.build/en/1066/