Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Function class #552

Open
ricardoV94 opened this issue Dec 13, 2023 · 0 comments · May be fixed by #955
Open

Simplify Function class #552

ricardoV94 opened this issue Dec 13, 2023 · 0 comments · May be fixed by #955
Labels
help wanted Extra attention is needed maintenance

Comments

@ricardoV94
Copy link
Member

Description

As discussed in #222 Function is quite bloated.

Some things we could probably remove because nobody uses them:

  1. Default values for function arguments
  2. output_subset kwarg at call_time

trust_input is useful for speedier evaluations, this should be an explicit kwarg to pytensorf.function and not just a hidden property that power-users know how to change after the function is created
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify the Function class HangenYuu/pytensor
1 participant
@ricardoV94