Fix 'function never returning' computation #9591
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit eb30f7c |
Pierre-Sassoulas
requested changes
May 3, 2024
There was a problem hiding this comment.
Hey thank you for taking over @antoniogamizbadger ! I feel like we lack some functional tests. (Shouldn't there be a Never used somewhere ?) That could be taken from the example in the original issue directly. Also the tests are not passing in the CI right now. When a message is expected in functional tests it's indicated with # [message-name] styile comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 bugs in the computation:
Never is handled in addition to NoReturn.
Give priority to the explicit --never-returning-functions option.
This PR was copied from #9535 (I cannot add commits there and we really need this).
Type of Changes
Description
Closes #7565