Add ignored modules to Astroid module deny list #9504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
the
Needs astroid update
Pierre-Sassoulas
previously approved these changes
Mar 18, 2024
jacobtylerwalls
requested changes
Apr 6, 2024
jacobtylerwalls
approved these changes
Apr 17, 2024
Merged
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
requested changes
May 7, 2024
There was a problem hiding this comment.
👋 @Jamie- I rebased your branch on main after we bumped astroid. Would you have a chance to look into the test failure by any chance? Thank you!
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
previously approved these changes
May 12, 2024
jacobtylerwalls
removed
the
Needs astroid update
Pierre-Sassoulas
approved these changes
May 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9504 +/- ##
==========================================
+ Coverage 95.82% 95.83% +0.01%
==========================================
Files 173 174 +1
Lines 18835 18888 +53
==========================================
+ Hits 18049 18102 +53
Misses 786 786
|
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 60add95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Adds ignored modules to the Astroid deny list so they may be truly ignored as they will now not be imported at all.
Depends on Astroid change pylint-dev/astroid#2399
Closes #9442