Fix linterstats.get_module_message_count() #9146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
reviewed
Oct 12, 2023
jacobtylerwalls
added
the
Waiting on author
There was a problem hiding this comment.
@zasca do you think you might have time to add automated tests for this ? It would be great if it could go in 3.0.3 :)
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
the
Needs take over ποΈ
Pierre-Sassoulas
removed
the
Waiting on author
jacobtylerwalls
removed
the
Needs take over ποΈ
jacobtylerwalls
requested review from
Pierre-Sassoulas
and removed request for
Pierre-Sassoulas
jacobtylerwalls
approved these changes
May 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9146 +/- ##
==========================================
+ Coverage 95.84% 95.86% +0.01%
==========================================
Files 174 174
Lines 18901 18904 +3
==========================================
+ Hits 18116 18122 +6
+ Misses 785 782 -3
|
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
approved these changes
May 18, 2024
There was a problem hiding this comment.
nt/checkouts/9146/doc/user_guide/messages/warning/implicit-str-concat.rst:55:
WARNING: Lexing literal_block '[STRING_CONSTANT]\ncheck-str-concat-over-line-jumps = yes'
as "toml" resulted in an error at token: 'y'. Retrying in relaxed mode.
Feel like this need a rebase on main /merge from main to be fixed. Otherwise LGTM
github-actions bot
pushed a commit
that referenced
this pull request
May 18, 2024
Co-authored-by: Jacob Walls <[email protected]> (cherry picked from commit d7526e3)
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 31b1fd6 |
|
Thanks for the contribution @zasca! |
jacobtylerwalls
pushed a commit
that referenced
this pull request
May 18, 2024
Co-authored-by: Jacob Walls <[email protected]> (cherry picked from commit d7526e3) Co-authored-by: zasca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #9145