-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Use custom backport action #10536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom backport action #10536
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10536 +/- ##
==========================================
- Coverage 95.84% 95.84% -0.01%
==========================================
Files 177 177
Lines 19282 19278 -4
==========================================
- Hits 18481 18477 -4
Misses 801 801 🚀 New features to boost your workflow:
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 6c6d2a4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ! Let's not move too much from the main branch in case we want to rebase on it or go back to it maybe ?
I agree. My main focus here was to a) bring it in a maintainable state / fix all security warnings and b) implement the user name and email inputs. I don't plan to do any more changes at the moment. https://github.com/pylint-dev/backport/security/dependabot?q=is%3Aclosed Tbh though I don't know if the upstream repo is even still maintained anymore. There hasn't been any activity for over two years. https://github.com/tibdex/backport
Just did that, looks like it worked out fine. All past commits are still attributed correctly. |
(cherry picked from commit 6f8da73)
(cherry picked from commit 6f8da73) Co-authored-by: Marc Mueller <[email protected]>
Description
Followup to #10396
I finally got around to forking and updating the backport action. I can be found here
https://github.com/pylint-dev/backport
tibdex/backport@main...pylint-dev:backport:main
The plan is to due only the bare minimum of maintenance there. So far I've
user_name
anduser_email
optionsI've configured the vars in the
pylint-dev
org selected for thepylint
andastroid
repos.Open question
Should we rename the
pylint-backport-bot[bot]
to justpylint-backport[bot]
? When I did set it up, I didn't know that Github would add[bot]
automatically. It's probably just a style thing. At most some commits in the maintenance branch won't be probably attributed to the bot anymore.I lean slightly towards doing it.
--
Will tag this one for the backport, just so we can see if everything worked out fine.