Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
A transform returning
Nonecurrently stops the remaining transforms becauseNone.__class__differs from the node's class. Only check for a type change whenthe transform returns a replacement. This preserves the current node and lets
later applicable transforms run, while retaining the existing stop behavior for
replacements of a different type.
Add regression tests for None returns, same-type and different-type replacements,
false predicates, and inference cache invalidation, plus a changelog entry.
Closes #809
Validation on Windows / Python 3.13.5:
afterward.
astroid/transforms.pyhas 100% line and branch coverage (50statements, 20 branches), including every changed line and branch.
both
OneandTwo.failures also occur on the unchanged production baseline. No new failures.
with the configured options using the installed Node runtime.
AI assistance: OpenAI Codex was used for implementation and validation, including
a separate AI review of the diff, regression tests and verification evidence.