Repository navigation
Give comprehension scopes a name so qname() does not crash - #3427
Open
Pierre-Sassoulas wants to merge 2 commits into
Open
Pierre-Sassoulas wants to merge 2 commits into
Pierre-Sassoulas wants to merge 2 commits into
Conversation
GeneratorExp, ListComp, SetComp and DictComp had no name attribute, so LocalsDictNodeNG.qname() raised AttributeError on them. Use the CPython code names, as Lambda already does with <lambda>. This also shows the name in their repr, e.g. <ListComp.<listcomp> l.1 at 0x...>.
Merging this PR will not alter performance
Comparing 
Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3427 +/- ##
=======================================
Coverage 91.15% 91.15%
=======================================
Files 93 93
Lines 11800 11804 +4
Branches 1938 1938
=======================================
+ Hits 10756 10760 +4
Misses 735 735
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
GeneratorExp, ListComp, SetComp and DictComp had no name attribute, so LocalsDictNodeNG.qname() raised AttributeError on them. Use the CPython code names, as Lambda already does with . This also shows the name in their repr, e.g. <ListComp. l.1 at 0x...>.