Skip to content

Cover untested branches in dict.fromkeys, dataclasses, constraints and decorators - #3425

Merged
Pierre-Sassoulas merged 1 commit into
pylint-dev:mainfrom
Pierre-Sassoulas:tests-uncovered-branches
Oct 22, 2026
Merged

Pierre-Sassoulas merged 1 commit into
pylint-dev:mainfrom
Pierre-Sassoulas:tests-uncovered-branches

Conversation

@Pierre-Sassoulas

Copy link
Copy Markdown
Member

Description

Add tests for:

  • dict.fromkeys() with a non-Const dict key and with a non-iterable argument
  • a parent dataclass field() without a default seen from a child
  • _CompoundConstraint.match on an expression that is not a BoolOp
  • a decorator factory returning a classmethod subclass

…d decorators

Add tests for:
- dict.fromkeys() with a non-Const dict key and with a non-iterable argument
- a parent dataclass field() without a default seen from a child
- _CompoundConstraint.match on an expression that is not a BoolOp
- a decorator factory returning a classmethod subclass
@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining astroid or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Oct 21, 2026
@codspeed

codspeed Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 3 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing Pierre-Sassoulas:tests-uncovered-branches (01162aa) with main (5395efb)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.12%. Comparing base (af39fd7) to head (01162aa).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3425      +/-   ##
==========================================
+ Coverage   90.96%   91.12%   +0.16%     
==========================================
  Files          93       93              
  Lines       11800    11800              
  Branches     1941     1939       -2     
==========================================
+ Hits        10734    10753      +19     
+ Misses        747      738       -9     
+ Partials      319      309      -10     
Flag Coverage Δ
linux 90.80% <ø> (+0.16%) ⬆️
pypy 91.12% <ø> (+0.16%) ⬆️
windows 90.96% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pierre-Sassoulas
Pierre-Sassoulas merged commit b530740 into pylint-dev:main Oct 22, 2026
37 of 38 checks passed
@Pierre-Sassoulas
Pierre-Sassoulas deleted the tests-uncovered-branches branch October 22, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance Discussion or action around maintaining astroid or the dev workflow Skip news 🔇 This change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant