Conversation
for more information, see https://pre-commit.ci
|
One thing this fix needs to consider is how the order of module discovery changes based on whether a user calls:
vs
The difference in behavior is described here in a stackoverflow post. The test fixes to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2531 +/- ##
==========================================
+ Coverage 92.98% 93.02% +0.03%
==========================================
Files 93 93
Lines 11049 11052 +3
==========================================
+ Hits 10274 10281 +7
+ Misses 775 771 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Sorry for not reviewing this sooner, this is the kind of change that are hard to assess/test and it's frightening 😅 |
|
No need to be sorry. I should reevaluate this given it has been a while since I have looked at this one. |
|
@akamat10 Are you still looking to pick this up again? |
Type of Changes
Description
no-membererror pylint#9883