Numpy reshape shape to use * #1999
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not really sure a unit test is needed here but if it does please let me know and hit to where it should be. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 94 94
Lines 10931 10931
=======================================
Hits 10141 10141
Misses 790 790
Flags with carried forward coverage won't be shown. Click here to find out more.
|
clavedeluna
added
the
pylint-tested
DanielNoord
reviewed
Feb 5, 2023
| @@ -120,7 +120,7 @@ def ptp(self, axis=None, out=None): return np.ndarray([0, 0]) | |||
| def put(self, indices, values, mode='raise'): return None | |||
| def ravel(self, order='C'): return np.ndarray([0, 0]) | |||
| def repeat(self, repeats, axis=None): return np.ndarray([0, 0]) | |||
| def reshape(self, shape, order='C'): return np.ndarray([0, 0]) | |||
| def reshape(self, *shape, order='C'): return np.ndarray([0, 0]) | |||
There was a problem hiding this comment.
The actual code is a bit different.. I'm not sure how to express this as it feels like we might run into issues with the other form as well..
Pierre-Sassoulas
requested changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes pylint-dev/pylint#7883
Pylint issue demonstrates a FP. I think this is the right solution, I also tested with this code and made sure pylint no longer showed the messages.