feat: Try multiple hash funcs files.get and files.put #1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fizzadar
reviewed
Jun 30, 2025
| if local_sum != remote_sum: | ||
| sum_match = False | ||
| for fact, get_sum in [ | ||
| # md5 is most common, so check it first |
There was a problem hiding this comment.
I think we should use sha1 as the first/default here to match the current implementation.
| # Check sha1sum, upload if needed | ||
| if local_sum != remote_sum: | ||
| sum_match = False | ||
| for fact, get_sum in [ |
There was a problem hiding this comment.
Probably makes sense to put this block into a util function and de-dupe with the above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support more hash functions for
files.put,files.get, on machine I'm working with does not support the sha1 commands, So with this PRmd5,sha1,sha264are tries in this orderMaybe this should be configurable?
3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)