Skip to content

[DRAFT] Tick-formatting for spharpy.plot.scatter#319

Draft
hoyer-a wants to merge 1 commit intomainfrom
bugfix/scatter-plot
Draft

[DRAFT] Tick-formatting for spharpy.plot.scatter#319
hoyer-a wants to merge 1 commit intomainfrom
bugfix/scatter-plot

Conversation

@hoyer-a
Copy link
Copy Markdown
Member

@hoyer-a hoyer-a commented Apr 10, 2026

Which issue(s) are closed by this pull request?

Closes #313

Changes proposed in this pull request:

  • always ensure equal axis aspect ratio when plotting samplings or subsets of samplings
  • based on centroid and extent of sampling

Examples

@hoyer-a hoyer-a force-pushed the bugfix/scatter-plot branch from 7a8cd21 to b0d4fcc Compare April 10, 2026 11:07
@hoyer-a hoyer-a added this to the v1.0.1 milestone Apr 10, 2026
@hoyer-a hoyer-a added bug Something isn't working plot labels Apr 10, 2026
@hoyer-a hoyer-a requested review from a team, ahms5, f-brinkmann, mberz, sikersten and tluebeck April 10, 2026 11:11
@hoyer-a hoyer-a moved this from Backlog to Require review in Weekly Planning Apr 10, 2026
Copy link
Copy Markdown
Member

@ahms5 ahms5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care. Have you recreate the baseline plots? I bet, sth would change there. I would also recomment to add a test, so that this woulnt happen again.

@hoyer-a hoyer-a marked this pull request as draft April 13, 2026 13:49
@hoyer-a hoyer-a moved this from Require review to Implementation in progress in Weekly Planning Apr 13, 2026
@hoyer-a hoyer-a force-pushed the bugfix/scatter-plot branch from b0d4fcc to aefa613 Compare April 14, 2026 12:16
@hoyer-a hoyer-a changed the title [Plots] Equal axis aspect ratio for spharpy.plot.scatter [DRAFT] Equal axis aspect ratio for spharpy.plot.scatter Apr 14, 2026
@hoyer-a hoyer-a changed the title [DRAFT] Equal axis aspect ratio for spharpy.plot.scatter [DRAFT] Tick-formatting for spharpy.plot.scatter Apr 20, 2026
@mberz
Copy link
Copy Markdown
Member

mberz commented May 5, 2026

Hey @hoyer-a, I was wondering if there's any progress on this? If no I think I'd prepare the next bug release without this PR included. I feel that the bugfixes currently waiting to be released are more urgent than this one, so don't worry if you don't have the bandwidth to finalize this one at the moment.

@hoyer-a
Copy link
Copy Markdown
Member Author

hoyer-a commented May 5, 2026

Not really, i made some progress with the tick locators and formatting but it's still no good solution.
I want to get something ready before friday, but if the bugfixes are really urgent i think this one can wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working plot

Projects

Status: Implementation in progress

Development

Successfully merging this pull request may close these issues.

[BUG] spharpy.plot.scatter axes collapse when plotting subsets of samplings

3 participants