Add typos check to pre-commit hooks #10040
Open
+103
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a bunch of typos. The work here was adding the exclusions (I had an LLM do them but also checked them)
max-sixty
commented
Feb 9, 2025
| @@ -63,6 +57,22 @@ io = [ | |||
| etc = ["sparse"] | |||
| parallel = ["dask[complete]"] | |||
| viz = ["cartopy", "matplotlib", "nc-time-axis", "seaborn"] | |||
| type-stubs = [ | |||
There was a problem hiding this comment.
I had meant to add this in a separate PR; I can do that if folks prefer / we need any discussion on it
max-sixty
commented
Feb 9, 2025
| @@ -73,3 +73,9 @@ repos: | |||
| hooks: | |||
| - id: validate-pyproject | |||
| additional_dependencies: ["validate-pyproject-schema-store[all]"] | |||
| - repo: https://github.com/crate-ci/typos | |||
There was a problem hiding this comment.
This is the typos project — it's great in PRQL. There's also a new-ish VSCode extension which has been good
|
Does anyone know what is "better", this or codespell #9781? |
Oh no! I didn't mean to come along with a different version. I have had a great experience with I guess at least this passes pre-commit? :) |
|
You could add [tool.typos.type.jupyter]
extend-ignore-re = [
"\"id\": \".*\"",
]to avoid correcting hashes in jupyter notebooks (crate-ci/typos#415 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a bunch of typos. The work here was adding the exclusions (I had an LLM do them but also checked them)