alternate proposal for version switcher #435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(apologies for all the extra changes in
static/vendor/in this PR; I started working in a fresh conda env and the fontawesome updates seem to have happened automatically as part of the yarn setup.)This PR is an alternative implementation to #433. It does the following:
_templates/switcher.htmlto create and populate a version-switcher dropdown.docs/_static/switcher.jsonas the source of version infotheme.confwith two new variables (switcher_json_urlandswitcher_template_url)docs/conf.pywith demo-site-appropriate values for those two new variables