Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix brand color example #2104

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Fix brand color example #2104

merged 4 commits into from
Jan 29, 2025

Conversation

drammock
Copy link
Collaborator

closes #2103

@drammock drammock added tag: CSS CSS and SCSS related issues kind: documentation Improvements or additions to documentation labels Jan 22, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

@drammock
Copy link
Collaborator Author

revised example looks OK: https://pydata-sphinx-theme--2104.org.readthedocs.build/en/2104/user_guide/header-links.html#fontawesome-icons

ready for review.

trallard
trallard approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thanks @drammock 🙏🏽

@trallard trallard merged commit b55ec41 into pydata:main Jan 29, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trallard trallard trallard approved these changes

Assignees
No one assigned
Labels
kind: documentation Improvements or additions to documentation tag: CSS CSS and SCSS related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS colors for Fontawesome icons do not work.
2 participants
@drammock @trallard