Match Sphinx toggle button and Sphinx Design hover and focus styles #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabalafou
commented
Nov 29, 2024
|
@smeragoel whenever you have a chance could you take a look at the hover and focus styles (light/dark) for the collapsible admonitions on the following two pages: |
Coverage report
This PR does not seem to contain any modification to coverable code. |
gabalafou
force-pushed
the
match-toggle-button
branch
from
3da6097 to
eac03c9
Compare
gabalafou
force-pushed
the
match-toggle-button
branch
from
eac03c9 to
dc89430
Compare
drammock
previously approved these changes
Dec 2, 2024
src/pydata_sphinx_theme/assets/styles/extensions/_togglebutton.scss
Outdated
Show resolved
Hide resolved
drammock
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the hover and focus styles more consistent for the various collapsible admonitions we support (Sphinx Design and Sphinx Toggle Button).
It also makes the focus rings better match the design system.
Screenshot of the admonition focus rings from the design system:
Screenshots from my local git branch, for comparison:
