Stop moving the Read the Docs version switcher into the sidebar #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
Carreau
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the Docs recently rolled out its new "addons" project. This broke assumptions made by code in our theme.
In particular, it means that all of the code that tries to move the Read the Docs version switcher into the sidebar no longer works, so this pull request removes all of that code and updates the docs.
I also removed the check for Read the Docs in the Ethical Ads template because as far as I understand, that template is opt-in anyway, meaning that sites that use our theme do not have that template included by default.
Fixes #1794 and possibly #1238.
This pull request does not address #1933, which is about providing a better integration with Read the Docs. The only goal of this pull request is to remove code that is broken as a result of the addons rollout.