Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Announcement banner does not disappear when remote HTML file contains end-of-file newline. #2102

Closed
AAriam opened this issue Jan 22, 2025 · 2 comments · Fixed by #2105
Closed

Announcement banner does not disappear when remote HTML file contains end-of-file newline. #2102

AAriam opened this issue Jan 22, 2025 · 2 comments · Fixed by #2105

Comments

@AAriam
Copy link
Contributor

AAriam commented Jan 22, 2025

Hi there,

when the remote announcement banner file contains only whitespace characters, the announcement banner does not disappear. This is inconvenient because many workflows automatically add an end-of-file newline to all files (e.g., linters; IDEs; even GitHub UIs do this by default). I think it'd be better to first strip the HTML before deciding whether it is empty or not.
@drammock
Copy link
Collaborator

good idea. do you have time to make a PR with that fix?

@AAriam AAriam mentioned this issue Jan 23, 2025
Merged
@AAriam
Copy link
Contributor Author

AAriam commented Jan 23, 2025 •
edited
Loading

Submitted PR #2105.

drammock added a commit that referenced this issue Jan 24, 2025
@AAriam @drammock
Strip whitespace from announcement file before processing. (#2105)
d5c1265 
Closes #2102

Co-authored-by: Daniel McCloy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Strip whitespace from announcement file before processing. AAriam/pydata-sphinx-theme
2 participants
@drammock @AAriam