New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for programmatic title generation #9183
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #9183 will not alter performanceComparing Summary
|
Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @NeevCohen,
Great work, as usual!
I want to look again at _generate_schema.py
and do a more in-depth look at your tests (great work btw, looks very thorough). This looks very promising though - I've included some initial feedback / some minor change requests.
One other change I'd like to see is the addition of some documentation in the concepts
section of our docs!
Co-authored-by: Sydney Runkle <[email protected]>
…eature/title-generators
@sydney-runkle Thanks! I implemented the changes you requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question : why not having title be a string or a callable that returns a string instead of two params?
This could be extended to alias generation for example with a context passed as arg in case of callable
@PrettyWood I implemented it the way the original issue suggested, I'm fine with changing it if we decide that is the way we want to go. |
@NeevCohen totally agree. Probably a change for v3 then |
@PrettyWood Awesome. |
Sorry for the delay, was out of the office last week. Looking now 🚀 ! Re your concepts docs question - your changes look great. We might want to add some more cross links with the config / fields sections, but it looks awesome thus far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here. Really impressed with the thorough testing, and great work on the docs as well.
Let's have @samuelcolvin do a final review of this given that he made the original feature request. Stay tuned! |
Apply suggestion Co-authored-by: Sydney Runkle <[email protected]>
Change Summary
Implement programmatic title generation via
ConfigDict
andField
Related issue number
fix #4632
Checklist
Selected Reviewer: @dmontagu