Allow ordering of constraints #825
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #825 will not alter performanceComparing Summary
|
davidhewitt
reviewed
Jul 26, 2023
| min_length: usize, | ||
| actual_length: usize, | ||
| }, | ||
| TooLong { | ||
| field_type: String, | ||
| max_length: usize, | ||
| actual_length: usize, |
There was a problem hiding this comment.
Removing this from the context may be a breaking change? Maybe can use the class name as the error message? This will also be nicer to see list or tuple instead of data.
There was a problem hiding this comment.
I tried that and had some trouble. Happy to revert this part of the change once we've gotten most of this PR into shape.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves constraints out of the parsing validators and into their own thing so that they can be re-ordered and to simplify core schema creation on the pydantic Python side.