Fix str subclass validation for enums

src/validators/enum_.rs

@@ -4,7 +4,8 @@ use std::marker::PhantomData;
 use pyo3::exceptions::PyTypeError;
 use pyo3::intern;
 use pyo3::prelude::*;
-use pyo3::types::{PyDict, PyList, PyType};
+use pyo3::types::PyString;
+use pyo3::types::{PyDict, PyFloat, PyInt, PyList, PyType};
 
 use crate::build_tools::{is_strict, py_schema_err};
 use crate::errors::{ErrorType, ValError, ValResult};
@@ -167,8 +168,22 @@ impl EnumValidateValue for PlainEnumValidator {
  py: Python<'py>,
  input: &I,
  lookup: &LiteralLookup<PyObject>,
- _strict: bool,
+ strict: bool,
  ) -> ValResult<Option<PyObject>> {
+ // if value is a subclass of str, use validate_str approach
+ if let Some(py_input) = input.as_python() {
+ if !strict {
+ if py_input.is_instance_of::<PyString>() {
+ return Ok(lookup.validate_str(input, false)?.map(|v| v.clone_ref(py)));
+ } else if py_input.is_instance_of::<PyInt>() {
+ return Ok(lookup.validate_int(py, input, false)?.map(|v| v.clone_ref(py)));
+ } else if py_input.is_instance_of::<PyFloat>() {
+ return Ok(lookup.validate_int(py, input, false)?.map(|v| v.clone_ref(py)));
+ }
+ }
+ }
+
+ // otherwise, use generic literal lookup
  Ok(lookup.validate(py, input)?.map(|(_, v)| v.clone_ref(py)))
  }
 }

tests/validators/test_enums.py

@@ -269,6 +269,52 @@ class MyEnum(Enum):
  SchemaValidator(core_schema.enum_schema(MyEnum, []))
 
 
+def test_enum_with_str_subclass() -> None:
+ class MyEnum(Enum):
+ a = 'a'
+ b = 'b'
+
+ v = SchemaValidator(core_schema.enum_schema(MyEnum, list(MyEnum.__members__.values())))
+
+ assert v.validate_python(MyEnum.a) is MyEnum.a
+ assert v.validate_python('a') is MyEnum.a
+
+ class MyStr(str):
+ pass
+
+ assert v.validate_python(MyStr('a')) is MyEnum.a
+ with pytest.raises(ValidationError):
+ v.validate_python(MyStr('a'), strict=True)
+
+
+def test_enum_with_int_subclass() -> None:
+ class MyEnum(Enum):
+ a = 1
+ b = 2
+
+ v = SchemaValidator(core_schema.enum_schema(MyEnum, list(MyEnum.__members__.values())))
+
+ assert v.validate_python(MyEnum.a) is MyEnum.a
+ assert v.validate_python(1) is MyEnum.a
+
+ class MyInt(int):
+ pass
+
+ assert v.validate_python(MyInt(1)) is MyEnum.a
+ with pytest.raises(ValidationError):
+ v.validate_python(MyInt(1), strict=True)
+
+
+def test_validate_float_for_int_enum() -> None:
+ class MyEnum(int, Enum):
+ a = 1
+ b = 2
+
+ v = SchemaValidator(core_schema.enum_schema(MyEnum, list(MyEnum.__members__.values())))
+
+ assert v.validate_python(1.0) is MyEnum.a
+
+
 def test_missing_error_converted_to_val_error() -> None:
  class MyFlags(IntFlag):
  OFF = 0