Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more form constraints #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add more form constraints #81

wants to merge 1 commit into from

Conversation

ischaojie
Copy link
Contributor

@ischaojie ischaojie commented Dec 8, 2023 •
edited
Loading

fixes #28

@codecov Codecov
Copy link

codecov bot commented Dec 8, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.72%. Comparing base (4605e6d) to head (d74e65d).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   95.68%   95.72%   +0.04%     
==========================================
  Files          14       14              
  Lines         950      959       +9     
==========================================
+ Hits          909      918       +9     
  Misses         41       41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ischaojie ischaojie marked this pull request as ready for review December 9, 2023 05:25
samuelcolvin
samuelcolvin reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good.

This needs to be rebased to main, and add tests for common cases.

@ischaojie ischaojie force-pushed the form branch 2 times, most recently from 0b250c8 to ce65758 Compare December 11, 2023 15:28
@ischaojie
Copy link
Contributor Author

Please review again. I'm not familiar with the json-schema part, feel free to request changes on it :)

samuelcolvin
samuelcolvin reviewed Dec 17, 2023
View reviewed changes
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, but some more to do I think.

samuelcolvin
samuelcolvin approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM.

Just conflicts to solve.

@ischaojie
Copy link
Contributor Author

Great, LGTM.

Just conflicts to solve.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin Awaiting requested review from samuelcolvin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More form constraints
2 participants
@ischaojie @samuelcolvin