Ptychography -> ImageStack & dm3 working #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kbschliep - thanks and great job! One small suggestion before this PR is merged - we need to keep a PtyochographyTranslator class that redirects / uses this ImageStackTranslator so that existing / legacy code does not break. A FutureWarning or DeprecationWarning should be added to the deprecated PtychographyTranslator class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed PtchographyTranslator to ImageStackTranslator
Opening folders of dm3's also works now after changing out read_image with read_dm3 and fixing a few related things. I also changed the hdf5 dataset names to be more general rather than specific for Ptychography.