Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind functions for dealing with sigalgs #7349

Merged
merged 1 commit into from
Jun 19, 2022
Merged

Bind functions for dealing with sigalgs #7349

merged 1 commit into from
Jun 19, 2022

Conversation

Jean-Daniel
Copy link
Contributor

Fixes #7336

@alex
Copy link
Member

alex commented Jun 19, 2022

thanks for sending this, looks like we need to expand the conditional to handle boringssl

@Jean-Daniel
Copy link
Contributor Author

Jean-Daniel commented Jun 19, 2022

Looking at BoringSSL history, they stated that SSL_get_sigalgs was "not terribly useful of APIs", and so decided to remove it long time ago.

Should we remove it too from this patch and only expose SSL_CTX_set1_sigalgs_list, or should we disable both functions and set Cryptography_HAS_SIGALGS to 0 when using BoringSSL ?

@alex
Copy link
Member

alex commented Jun 19, 2022 via email

Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alex alex enabled auto-merge (squash) June 19, 2022 21:46
@alex alex merged commit a8e3a0a into pyca:main Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add SSL_CTX_set1_sigalgs_list() binding.
2 participants