Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSL_CTX_set1_sigalgs_list() binding. #7336

Closed
Jean-Daniel opened this issue Jun 15, 2022 · 1 comment · Fixed by #7349
Closed

Add SSL_CTX_set1_sigalgs_list() binding. #7336

Jean-Daniel opened this issue Jun 15, 2022 · 1 comment · Fixed by #7349

Comments

@Jean-Daniel
Copy link
Contributor

Jean-Daniel commented Jun 15, 2022 •
edited
Loading

For the same reason as it was added some years ago (#4006) SSL_CTX_set1_sigalgs_list() is required to control how to connect to a TLS 1.3 server.

And it is required to implements pyca/pyopenssl#848

As TLS 1.3 is becoming common, this is even more important to be able to access this function than before.

Could it be possible to revert #6473
@alex
Copy link
Member

alex commented Jun 19, 2022

We'd accept a patch reverting that PR.

Jean-Daniel added a commit to Jean-Daniel/cryptography that referenced this issue Jun 19, 2022
@Jean-Daniel
Bind functions for dealing with sigalgs
4730856 
Fixes pyca#7336
Jean-Daniel added a commit to Jean-Daniel/cryptography that referenced this issue Jun 19, 2022
@Jean-Daniel
Bind functions for dealing with sigalgs
b74683f 
Fixes pyca#7336
@Jean-Daniel Jean-Daniel mentioned this issue Jun 19, 2022
Merged
Jean-Daniel added a commit to Jean-Daniel/cryptography that referenced this issue Jun 19, 2022
@Jean-Daniel
Bind functions for dealing with sigalgs
b257c45 
Fixes pyca#7336
alex pushed a commit that referenced this issue Jun 19, 2022
@Jean-Daniel
Bind functions for dealing with sigalgs (#7349)
a8e3a0a 
Fixes #7336
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bind functions for dealing with sigalgs Jean-Daniel/cryptography
2 participants
@alex @Jean-Daniel