Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback to pyo3 = { version = "0.16.6", features = ["abi3"] } #714

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rollback to pyo3 = { version = "0.16.6", features = ["abi3"] } #714

wants to merge 1 commit into from

Conversation

hswong3i
Copy link

@hswong3i hswong3i commented Jan 3, 2024 •
edited
Loading

In order to avoid ImportError: PyO3 modules compiled for CPython 3.8 or older may only be initialized once per interpreter process introduced since pyo3 >= 0.17.0, which only allow each #[pymodule] to be initialized once, this PR temporarily rollback to pyo3 = 0.16.6.

It also remove the use of PyUserWarning which introduced since pyo3 > 0.18.0.

See PyO3/pyo3@78ba70d
See PyO3/pyo3@1d20f2a

Fixes #694

hswong3i added a commit to alvistack/pyca-bcrypt that referenced this pull request Jan 3, 2024
@hswong3i
alvistack/4.1.1
f863edb 
    git clean -xdf
    mkdir -p .cargo
    cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
    tar zcvf ../python-bcrypt_4.1.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-bcrypt.spec ../python-bcrypt_4.1.1-1.spec
    cp ../python*-bcrypt*4.1.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.1.1/
    rm -rf ../python*-bcrypt*4.1.1*.*

See pyca#695
See pyca#714

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i added a commit to alvistack/pyca-bcrypt that referenced this pull request Jan 3, 2024
@hswong3i
alvistack/4.1.2
9e9e2ee 
    git clean -xdf
    mkdir -p .cargo
    cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
    tar zcvf ../python-bcrypt_4.1.2.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-bcrypt.spec ../python-bcrypt_4.1.2-1.spec
    cp ../python*-bcrypt*4.1.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.1.2/
    rm -rf ../python*-bcrypt*4.1.2*.*

See pyca#714

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i added a commit to alvistack/pyca-bcrypt that referenced this pull request Jan 3, 2024
@hswong3i
alvistack/4.1.2
11b6db6 
    git clean -xdf
    mkdir -p .cargo
    cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
    tar zcvf ../python-bcrypt_4.1.2.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-bcrypt.spec ../python-bcrypt_4.1.2-1.spec
    cp ../python*-bcrypt*4.1.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.1.2/
    rm -rf ../python*-bcrypt*4.1.2*.*

See pyca#714

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i added a commit to alvistack/pyca-bcrypt that referenced this pull request Jan 3, 2024
@hswong3i
alvistack/4.1.1
b0f6f47 
    git clean -xdf
    mkdir -p .cargo
    cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
    tar zcvf ../python-bcrypt_4.1.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-bcrypt.spec ../python-bcrypt_4.1.1-1.spec
    cp ../python*-bcrypt*4.1.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.1.1/
    rm -rf ../python*-bcrypt*4.1.1*.*

See pyca#695
See pyca#714

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
@hswong3i hswong3i mentioned this pull request Jan 3, 2024
Open
@alex
Copy link
Member

alex commented Jan 3, 2024

This does not actually fix the issue, it merely removes the error -- pyo3 modules still do not support sub-interpreters.

@hswong3i
Copy link
Author

hswong3i commented Jan 3, 2024

Yes this PR doesn't solve the problem but just rolling back as original behavior...

BTW I couldn't see any schedule for PyO3/pyo3#576 getting done...

If we don't really depends on features provided by pyo3 >= 0.17.0, at least this PR will not block the use of bcrypt on Ceph...

hswong3i added a commit to alvistack/pyca-bcrypt that referenced this pull request Feb 24, 2024
@hswong3i
alvistack/4.1.1
fa2ec78 
    git clean -xdf
    mkdir -p .cargo
    cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
    tar zcvf ../python-bcrypt_4.1.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-bcrypt.spec ../python-bcrypt_4.1.1-1.spec
    cp ../python*-bcrypt*4.1.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.1.1/
    rm -rf ../python*-bcrypt*4.1.1*.*

See pyca#695
See pyca#714

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i added a commit to alvistack/pyca-bcrypt that referenced this pull request Feb 24, 2024
@hswong3i
alvistack/4.1.2
69805d5 
    git clean -xdf
    mkdir -p .cargo
    cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
    tar zcvf ../python-bcrypt_4.1.2.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-bcrypt.spec ../python-bcrypt_4.1.2-1.spec
    cp ../python*-bcrypt*4.1.2*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.1.2/
    rm -rf ../python*-bcrypt*4.1.2*.*

See pyca#714

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
@pipiche38 pipiche38 mentioned this pull request Apr 4, 2024
Closed
hswong3i added a commit to alvistack/pyca-bcrypt that referenced this pull request May 4, 2024
@hswong3i
alvistack/4.1.3
c249487 
    git clean -xdf
    mkdir -p .cargo
    cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
    tar zcvf ../python-bcrypt_4.1.3.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-bcrypt.spec ../python-bcrypt_4.1.3-1.spec
    cp ../python*-bcrypt*4.1.3*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.1.3/
    rm -rf ../python*-bcrypt*4.1.3*.*

See pyca#714

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
@hswong3i
Rollback to pyo3 = { version = "0.16.6", features = ["abi3"] }
ec38f43 
In order to avoid `ImportError: PyO3 modules compiled for CPython 3.8 or
older may only be initialized once per interpreter process` introduced
since pyo3 >= 0.17.0, which only allow each `#[pymodule]` to be
initialized once, this PR temporarily rollback to pyo3 = 0.16.6.

It also remove the use of `PyUserWarning` which introduced since pyo3 >
0.18.0.

See PyO3/pyo3@78ba70d
See PyO3/pyo3@1d20f2a

Fixes pyca#694

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
@hswong3i
Copy link
Author

hswong3i commented May 4, 2024

Still, this is not a good idea for rollback; but well, PyO3/pyo3#576 have no progress as expected...

So at least an update for 4.1.3 + force push for this PR, used with my:

hswong3i added a commit to alvistack/pyca-bcrypt that referenced this pull request Jul 23, 2024
@hswong3i
alvistack/4.2.0
61b42e7 
    git clean -xdf
    mkdir -p .cargo
    cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
    tar zcvf ../python-bcrypt_4.2.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-bcrypt.spec ../python-bcrypt_4.2.0-1.spec
    cp ../python*-bcrypt*4.2.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.2.0/
    rm -rf ../python*-bcrypt*4.2.0*.*

See pyca#714

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i added a commit to alvistack/pyca-bcrypt that referenced this pull request Jul 23, 2024
@hswong3i
alvistack/4.2.0
3f294c9 
    git clean -xdf
    mkdir -p .cargo
    cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
    tar zcvf ../python-bcrypt_4.2.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-bcrypt.spec ../python-bcrypt_4.2.0-1.spec
    cp ../python*-bcrypt*4.2.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.2.0/
    rm -rf ../python*-bcrypt*4.2.0*.*

See pyca#714

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i added a commit to alvistack/pyca-bcrypt that referenced this pull request Jul 23, 2024
@hswong3i
alvistack/4.2.0
ea07f42 
    git clean -xdf
    mkdir -p .cargo
    cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
    tar zcvf ../python-bcrypt_4.2.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-bcrypt.spec ../python-bcrypt_4.2.0-1.spec
    cp ../python*-bcrypt*4.2.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.2.0/
    rm -rf ../python*-bcrypt*4.2.0*.*

See pyca#714

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i added a commit to alvistack/pyca-bcrypt that referenced this pull request Nov 16, 2024
@hswong3i
alvistack/4.2.0
2feb030 
    git clean -xdf
    mkdir -p .cargo
    cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
    tar zcvf ../python-bcrypt_4.2.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-bcrypt.spec ../python-bcrypt_4.2.0-1.spec
    cp ../python*-bcrypt*4.2.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.2.0/
    rm -rf ../python*-bcrypt*4.2.0*.*

See pyca#714

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i added a commit to alvistack/pyca-bcrypt that referenced this pull request Nov 16, 2024
@hswong3i
alvistack/4.2.0
c3e0e45 
    git clean -xdf
    mkdir -p .cargo
    cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
    tar zcvf ../python-bcrypt_4.2.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-bcrypt.spec ../python-bcrypt_4.2.0-1.spec
    cp ../python*-bcrypt*4.2.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.2.0/
    rm -rf ../python*-bcrypt*4.2.0*.*

See pyca#714

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i added a commit to alvistack/pyca-bcrypt that referenced this pull request Nov 16, 2024
@hswong3i
alvistack/4.2.0
29c3eaf 
    git clean -xdf
    mkdir -p .cargo
    cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
    tar zcvf ../python-bcrypt_4.2.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-bcrypt.spec ../python-bcrypt_4.2.0-1.spec
    cp ../python*-bcrypt*4.2.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.2.0/
    rm -rf ../python*-bcrypt*4.2.0*.*

See pyca#714

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i added a commit to alvistack/pyca-bcrypt that referenced this pull request Nov 19, 2024
@hswong3i
alvistack/4.2.1
381acfc 
    git clean -xdf
    mkdir -p .cargo
    cargo vendor --manifest-path ./src/_bcrypt/Cargo.toml > .cargo/config.toml
    tar zcvf ../python-bcrypt_4.2.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-bcrypt.spec ../python-bcrypt_4.2.1-1.spec
    cp ../python*-bcrypt*4.2.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/pyca-bcrypt-4.2.1/
    rm -rf ../python*-bcrypt*4.2.1*.*

See pyca#714

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@hswong3i @alex