-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: squash-merge smart_holder branch into master #5542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rwgk
merged 30 commits into
pybind:master
from
rwgk:squash_merge_smart_holder_into_master_previews
Mar 5, 2025
Merged
Changes from 15 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
cd1c9d4
Pure `git merge --squash smart_holder` (no manual interventions).
rwgk f01bc09
Remove ubench/ directory.
rwgk 4d8973e
Remove include/pybind11/smart_holder.h
rwgk c807ec3
[ci skip] smart_ptrs.rst updates [WIP/unfinished]
rwgk 76f4da3
[ci skip] smart_ptrs.rst updates continued; also updating classes.rst…
rwgk eb550d0
Remove README_smart_holder.rst
rwgk 860d58e
Restore original README.rst from master
rwgk 6bf9e88
[ci skip] Minimal change to README.rst, to leave a hint that this is …
rwgk f4ad02b
[ci skip] Work in ChatGPT suggestions.
rwgk 7cae21f
Change macro name to PYBIND11_RUN_TESTING_WITH_SMART_HOLDER_AS_DEFAUL…
rwgk 388fa99
Add a note pointing to the holder reinterpret_cast.
rwgk 449cceb
Incorporate suggestion by @virtuald: https://github.com/pybind/pybind…
rwgk ac9d31e
Systematically change most py::class_ to py::classh under docs/
rwgk a4cfd38
Remove references to README_smart_holder.rst
rwgk 046883c
[ci skip] Fix minor oversight (``class_`` -> ``py::class_``) noticed …
rwgk 4cc528d
[ci skip] Resolve suggestion by @virtuald
rwgk 5f1d646
[ci skip] Apply suggestions by @timohl (thanks!)
rwgk ff7c087
Replace `classh : class_` inhertance with `using`, as suggested by @h…
rwgk 1e646c9
Revert "Systematically change most py::class_ to py::classh under docs/"
henryiii 7dc507e
docs: focus on py::smart_holder instead of py::classh
henryiii 8409b19
Restore minor general fixes that got lost when ac9d31e13fd15f2a8e3dee…
rwgk 85cc92d
Remove `- smart_holder` from list of branches in all .github/workflows
rwgk b73f430
Extend classh note to explain whitespace noise motivation.
rwgk d3f9f93
Suggest `py::smart_holder` for "most situations for safety"
rwgk 4b05643
Add back PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT
rwgk b50bf21
Add py::trampoline_self_life_support to all trampoline examples under…
rwgk 5b5be0e
Fix whitespace accident (indentation) introduced with 1e646c91b4cfd78…
rwgk 9bb8d06
WHITESPACE CHANGES ONLY in README.rst (list of people that made signi…
rwgk b9bf98a
Add Ethan Steinberg to list of people that made significant contribut…
rwgk 8e432e9
[ci skip] Add to list of people that made significant contributions: …
rwgk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ on: | |
branches: | ||
- master | ||
- stable | ||
- smart_holder | ||
- v* | ||
|
||
permissions: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ on: | |
branches: | ||
- master | ||
- stable | ||
- smart_holder | ||
- v* | ||
|
||
concurrency: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ on: | |
branches: | ||
- master | ||
- stable | ||
- smart_holder | ||
- "v*" | ||
|
||
permissions: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ on: | |
branches: | ||
- master | ||
- stable | ||
- smart_holder | ||
- v* | ||
release: | ||
types: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.