Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple workaround for pyside 6 #119

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Oct 3, 2022

I found that recent version of pyside6 overwrite str method of Enum class, so checking if str method belongs either to enum or shibokensupport modules solves this problem.

But I'm not sure if it is a goo d idea as it may impact on some related enums.

Maybe the best option will be to wait on the next PySide6 release? Maybe they will solve it?

fixes: #118

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #119 (bc5f91b) into main (f401d6d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   84.94%   84.94%           
=======================================
  Files          30       30           
  Lines        2391     2391           
=======================================
  Hits         2031     2031           
  Misses        360      360           
Impacted Files Coverage Δ
src/superqt/combobox/_enum_combobox.py 93.84% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Czaki
Copy link
Contributor Author

Czaki commented Oct 3, 2022

imageio just released a new version
https://pypi.org/project/imageio/#history

imageio/imageio#887

@tlambert03
Copy link
Member

this works fine for me. we can iterate if/when pyside changes in the future. thanks @Czaki!

@tlambert03 tlambert03 merged commit 04efa95 into pyapp-kit:main Oct 3, 2022
@tlambert03 tlambert03 added tests related to tests or CI bug Something isn't working and removed tests related to tests or CI labels Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Enum Combo tests failing on PyQt6
2 participants