Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add io and cli #21

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: add io and cli #21

wants to merge 14 commits into from

Conversation

tlambert03
Copy link
Member

closes #4

this PR adds a cli command ndv ... and attempts to read basically anything 😂 as per @alisterburt request :)

it's a work in progress... would be installed via pip install ndv[io] and would lean heavily on aicsimagieo (or bioio, not sure yet) as well as some additional stuff

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 100 lines in your changes missing coverage. Please review.

Project coverage is 70.19%. Comparing base (c1be08a) to head (324cff4).

Files with missing lines Patch % Lines
src/ndv/io.py 0.00% 88 Missing ⚠️
src/ndv/cli.py 0.00% 10 Missing ⚠️
src/ndv/v1/_old_viewer.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   71.71%   70.19%   -1.52%     
==========================================
  Files          43       45       +2     
  Lines        4430     4533     +103     
==========================================
+ Hits         3177     3182       +5     
- Misses       1253     1351      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@alisterburt alisterburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooove it, just got off the plane but excited to give it a whirl! Thanks for the effort 🙂

src/ndv/io.py Outdated


def imread(path: str | Path) -> Any:
"""Just read the thing already."""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@tlambert03 tlambert03 mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: command line interface
2 participants