Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix #1709 #1710

Merged
merged 2 commits into from
May 17, 2024
Merged

fix: fix #1709 #1710

merged 2 commits into from
May 17, 2024

Conversation

hbredin
Copy link
Member

@hbredin hbredin commented May 15, 2024

cc @FrenchKrab can you please check it solves your issue #1709?

Disclaimer: I did not do any test :)

Copy link
Collaborator

@clement-pages clement-pages left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbredin hbredin marked this pull request as ready for review May 15, 2024 12:08
@FrenchKrab
Copy link
Contributor

It does solve the issue !

@hbredin hbredin merged commit cad8bea into develop May 17, 2024
4 checks passed
@hbredin hbredin deleted the fix/1709 branch May 17, 2024 13:39
@hbredin
Copy link
Member Author

hbredin commented May 17, 2024

Merged in develop. Will be part of next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants