updated icon and enabled popup

pwa-builder · Mar 25, 2022 · 7a92e41 · 7a92e41
1 parent 57caea3
commit 7a92e41
Show file tree

Hide file tree

Showing 9 changed files with 24 additions and 7 deletions.
diff --git a/public/icon/128.png b/public/icon/128.png
diff --git a/public/icon/16.png b/public/icon/16.png
diff --git a/public/icon/32.png b/public/icon/32.png
diff --git a/public/icon/48.png b/public/icon/48.png
diff --git a/public/icon_512.png → public/icon/512.png b/public/icon_512.png → public/icon/512.png
diff --git a/public/manifest.json b/public/manifest.json
@@ -8,11 +8,19 @@
   },
   "permissions": ["tabs", "scripting", "downloads"],
   "host_permissions": ["http://*/", "https://*/"],
-  "action": {},
+  "action": {
+    "default_popup": "panel.html"
+  },
   "content_scripts" : [
     {
       "js": ["partnerCenter.js"],
       "matches": ["*://partner.microsoft.com/*"]
     }
-  ]
+  ],
+  "icons": {
+    "16": "icon/16.png",
+    "32": "icon/32.png",
+    "48": "icon/48.png",
+    "128": "icon/128.png"
+  }
 }
diff --git a/public/panel.html b/public/panel.html
@@ -2,6 +2,9 @@
 
 <head>
   <link rel="stylesheet" href="shoelace/light.css" />
+  <style>
+    html{min-height:500px;min-width:500px}
+  </style>
 </head>
 
 <body>  

diff --git a/src/devtools.ts b/src/devtools.ts
@@ -1,6 +1,6 @@
 chrome.devtools.panels.create("PWA Builder",
-            "icon_512.png",
-            "panel.html",
-            (panel) => {
-                console.log(panel);
-            });
+    "icon/512.png",
+    "panel.html",
+    (panel) => {
+        console.log(panel);
+    });
diff --git a/src/partnerCenter.ts b/src/partnerCenter.ts
@@ -126,6 +126,12 @@ async function loadExtension() {
 
         let nameList = publisherData.Name.split('.');
         let name = nameList[nameList.length - 1];
+
+        // TODO for version
+        // we should provide option for dev to enter version
+        // but we can also be smart and use the partner center api to see what package versions are already submitted 
+        // and generate a new version that's higher
+        // https://partner.microsoft.com/dashboard/packages/api/pkg/v2.0/packagesets?productId=9PGB0X13X6QZ&submissionId=1152921505694665183&select=Validations
 
         const windowsOptions: WindowsOptions = {
             url,
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,9 @@ @@
     <head>
       <link rel="stylesheet" href="shoelace/light.css" />
+      <style>
+        html{min-height:500px;min-width:500px}
+      </style>
     </head>
     <body>
@@ Expand Down @@