add internal descriptions to worktimes (63818) #229
Merged
+112
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-illi
changed the title
kronn
changed the title
kronn
approved these changes
Mar 6, 2025
|
@kronn when migrating the db, the schema is reformatted in quite a few places. Are these changes okay or was there some misconfiguration on my side? |
Can be okay. Are you using the same DB-version as in production, on CI and as everyone else? If so, then yes, it is okay. If there are differences in the setup, these should be addressed first. |
|
As far as I know, it should be the same |
|
However, I would be thankful if this could be verified and some other person can generate the schema themselves. Just to make sure that my setup was correct. |
Kagemaru
force-pushed
the
feature/63818-add_field_internal_remarks_
branch
2 times, most recently
from
1f67f58 to
c200487
Compare
these internal descriptions are displayed in puzzletime, and in the csv export, but not in the time rapport
Kagemaru
force-pushed
the
feature/63818-add_field_internal_remarks_
branch
from
c200487 to
94b93df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these internal descriptions are displayed in puzzletime, and in the csv export, but not in the time rapport