Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve issue with variable names like $in or $struct #748

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solve issue with variable names like $in or $struct #748

wants to merge 2 commits into from

Commits on Mar 12, 2024

  1. lang: parser: Grab entire variable names during lexing 

    This is inelegant, but I stronly believe that allowing dollar signs and their
variable name suffixes to both be first class citizens, is a bad idea.
The dollar sign should initiate a token that is exempt from any other
processing.

Note that it would be possible to construct a regex similar to the one for
IDENTIFIER, that only matches valid variable names. But it will be complex.
It seems more maintainable to just consume all allowed characters, and then
check validity with some simple golang in the parser actions.

Fixes purpleidea#728
    @ffrank
    ffrank committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    2f8677b View commit details
    Browse the repository at this point in the history

  2. test: vet: Avoid choking on boolean OR in parser actions

    @ffrank
    ffrank committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    a714341 View commit details
    Browse the repository at this point in the history