Include type declaration SourceAnn for values #4471
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This allows the compiler to be more honest about the source annotation for value declarations. During desugaring, the
SourceAnn
for a value declaration is replaced with a corresponding type declaration'sSourceAnn
if it exists.I noticed this while working on #4247 and it messes up the order for constructing the interval tree
which I intend to serialize into a file/use in
psc-ide
as part of the type-on-hover stuff.Another solution for this is to expand the annotation during desugaring such that both the annotation and value declaration is covered, but this changes behaviour in error messages.
Checklist: