Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change [System.Environment]::SetEnvironmentVariable() to Set-ItemProperty #365

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pkotov87
Copy link

Summary

Here was the method of set PSPath-Variable changed from [System.Environment]::SetEnvironmentVariable() to Set-ItemProperty. This brings a performance advantage, because the function can have [System.Environment]::SetEnvironmentVariable() timeouts (see also).

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

#363

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@pkotov87 pkotov87 requested a review from a team as a code owner January 29, 2025 11:09
@CLAassistant
Copy link

CLAassistant commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Paul Kotov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pkotov87 pkotov87 force-pushed the main branch 3 times, most recently from 50a7ea9 to 2f47c0a Compare January 29, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants