Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker_compose up_args #997

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mcarrolle
Copy link

@mcarrolle mcarrolle commented Sep 12, 2024

Summary

Fix wrong position of up_args arguments passed to command and handle up_args argument that contains value like --pull always.
Issue: #984 and #996

Additional Context

Related Issues (if any)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@mcarrolle mcarrolle requested a review from a team as a code owner September 12, 2024 12:55
@KoenDierckx
Copy link

Any updates on this, it is blocking our upgrade of the module ?

@rogermartensson
Copy link

(I am not code owner)

I wonder if the argument validation for up_args is correct in the ruby-code for the docker_compose type?
Input should be an array but error says it should be a String.

I also notices that this pullrequests has failing CI-tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants