Simplify Rakefile #9331
Merged
Simplify Rakefile #9331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves all Rake tasks not defined in the Rakefile to a new rakelib directory, where Rake will autodiscover and import those tasks. Additionally, I've removed old logic in the Rakefile that manually specified where to find and how to import those tasks.
Previous versions of the Rakefile relied on Puppet#version as part of a packaging task. That packaging task was removed from the Rakefile in 2012 in b1648b2, so we no longer need to load the Puppet library and require puppet/version.
joshcooper
approved these changes
May 21, 2024
|
LGTM could you check that one of the benchmarks can be run before merging (if you didn't already)? |
Just ran the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During recent work on streamlining the process to build Puppet as a gem, I noticed several parts of the Rakefile that were added for historical reasons, but are no longer needed. This PR comprises changes to simplify the Rakefile.