Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-256) Puppetfile dependency endpoint #255

Merged
merged 1 commit into from
Jun 4, 2020
Merged

(GH-256) Puppetfile dependency endpoint #255

merged 1 commit into from
Jun 4, 2020

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented May 28, 2020 •
edited
Loading

@jpogran jpogran added this to the 0.26.1 milestone May 28, 2020
@jpogran jpogran self-assigned this May 28, 2020
@jpogran jpogran force-pushed the gh-666-puppetfile-view branch 4 times, most recently from e4c8a7e to 4878590 Compare June 1, 2020 18:04
@jpogran jpogran added the enhancement New feature or request label Jun 1, 2020
@jpogran jpogran marked this pull request as ready for review June 1, 2020 18:13
@jpogran jpogran marked this pull request as draft June 2, 2020 16:03
@jpogran jpogran force-pushed the gh-666-puppetfile-view branch 2 times, most recently from 1d61662 to 631eade Compare June 2, 2020 17:33
@jpogran jpogran marked this pull request as ready for review June 2, 2020 17:33
@jpogran jpogran requested a review from glennsarti June 2, 2020 17:46
@jpogran jpogran changed the title gh 666 puppetfile view (GH-256) Puppetfile dependency endpoint Jun 2, 2020
@jpogran jpogran linked an issue Jun 2, 2020 that may be closed by this pull request
puppetfile-resolver endpoint #256
Closed
@jpogran
Copy link
Contributor Author

jpogran commented Jun 3, 2020

@glennsarti please review during our sync up tonight

glennsarti
glennsarti reviewed Jun 3, 2020
View reviewed changes
Gemfile Outdated Show resolved Hide resolved
glennsarti
glennsarti approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@glennsarti glennsarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending removal of gem stuff

@jpogran
(puppetlabsGH-256) Add puppetfile-resolver endpoint
77878f3 
Adds a new endpoint for parsing a Puppetfile and returning a list of modules. This only returns forge modules right now because those are the only ones that are resolved by puppetfile-resolver currently.
@glennsarti glennsarti merged commit 8a1baa4 into puppetlabs:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennsarti glennsarti glennsarti approved these changes

Assignees

@jpogran jpogran

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.26.1
Development

Successfully merging this pull request may close these issues.

puppetfile-resolver endpoint
2 participants
@jpogran @glennsarti