Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: providing null to page.authenticate should disable authentication #12203

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: providing null to page.authenticate should disable authentication #12203

wants to merge 2 commits into from

Conversation

Lightning00Blade
Copy link
Collaborator

Aligns with our documentation that tell's we can use null to disable,
Providing user/pass with undefined did not disable the Fetch domain as it should.

@OrKoN
Copy link
Collaborator

OrKoN commented Apr 4, 2024

fix: providing null to page.authenticate should disable authentication (perhaps a better title)

@Lightning00Blade Lightning00Blade changed the title fix: disabling of authentication fix: providing null to page.authenticate should disable authentication Apr 4, 2024
@Lightning00Blade Lightning00Blade enabled auto-merge (squash) April 4, 2024 10:53
@OrKoN OrKoN force-pushed the main branch 4 times, most recently from 2ff1e4f to e0932e5 Compare April 16, 2024 09:37
@Lightning00Blade Lightning00Blade mentioned this pull request Apr 23, 2024
Merged
@Lightning00Blade
Copy link
Collaborator Author

Lightning00Blade commented Apr 26, 2024 •
edited

Testing again with 125.0.6422.14 seems to work so waiting till that or newer version rolls to stable to re test.
https://gist.github.com/Lightning00Blade/338850f93f6379a60a414aaa3ea6ed99

@OrKoN
Copy link
Collaborator

OrKoN commented May 15, 2024

@Lightning00Blade can this be landed?

@OrKoN
Copy link
Collaborator

OrKoN commented May 15, 2024

ah waiting for m125

@OrKoN OrKoN added the m125 label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE m125
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lightning00Blade @OrKoN