net: mqtt: Add missing mutex_unlock

mqtt_connect was not releasing mutex after successfull connection. Reworked the code to have a single exit path with mutex unlock. Signed-off-by: Robert Lubos <[email protected]>
punitvara · Nov 28, 2018 · a26db60 · a26db60
1 parent 21224a9
commit a26db60
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/subsys/net/lib/mqtt_sock/mqtt.c b/subsys/net/lib/mqtt_sock/mqtt.c
@@ -185,16 +185,14 @@ int mqtt_connect(struct mqtt_client *client)
 	}
 
 	err_code = client_connect(client);
+
+error:
 	if (err_code < 0) {
-		err_code = -ECONNREFUSED;
-		goto error;
+		client_reset(client);
 	}
 
-	return 0;
-
-error:
-	client_reset(client);
 	mqtt_mutex_unlock(client);
+
 	return err_code;
 }