Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix folder archives in the engine #16119

Merged
merged 1 commit into from May 6, 2024
Merged

Fix folder archives in the engine #16119

merged 1 commit into from May 6, 2024

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented May 3, 2024

Description

Fixes #16092.

Last part of the fix started in #16100. That last PR fixed assets and archive files, but not archive folders.

Checklist

  • I have run make tidy to update any new dependencies
  • I have run make lint to verify my code passes the lint check
    • I have formatted my code using gofumpt
  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

@pulumi-bot
Copy link
Contributor

pulumi-bot commented May 3, 2024

Changelog

[uncommitted] (2024-05-03)

Bug Fixes

  • [engine] Fix folder archive outside of cwd.
    #16119

@Frassle Frassle marked this pull request as ready for review May 3, 2024 19:36
@Frassle Frassle requested a review from a team as a code owner May 3, 2024 19:36
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinvp justinvp added this pull request to the merge queue May 6, 2024
@justinvp justinvp mentioned this pull request May 6, 2024
Merged via the queue into master with commit 3d4291e May 6, 2024
49 checks passed
@justinvp justinvp deleted the fraser/fixFolderArchive branch May 6, 2024 08:21
github-merge-queue bot pushed a commit that referenced this pull request May 6, 2024
To be merged after #16119 merges.

Tentative changelog:

- [backend] Fix concurrent reads from and writes to display resource
timer maps
  [#16101](#16101)

- [engine] Better handle property dependencies and deleted-with
relationships when pruning URNs, verifying snapshot integrity and
computing dependency graphs.
  [#16088](#16088)

- [programgen/python] Sort generated requirements.txt files when
generating Python programs
  [#16115](#16115)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants