Provide a better error message during pulumi new if no nodejs package manager is installed #16096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-05-03)Bug Fixes
|
tgummerer
approved these changes
May 2, 2024
… manager is installed
julienp
force-pushed
the
julienp/pulumi-new-npm-error
branch
from
a53dec0
to
741caba
Compare
Frassle
reviewed
May 3, 2024
| @@ -100,8 +101,8 @@ func ResolvePackageManager(pwd string) (PackageManager, error) { | |||
| // Finally, fall back to npm. | |||
| node, err := newNPM() | |||
| if err != nil { | |||
| return nil, fmt.Errorf("could not find npm on the $PATH; npm is installed with Node.js "+ | |||
| "available at https://nodejs.org/: %w", err) | |||
There was a problem hiding this comment.
We ok dropping the ref to the website to download from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13542
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change