Style refactor: use contract.Assertf instead of panic #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1527 +/- ##
==========================================
- Coverage 62.01% 57.96% -4.05%
==========================================
Files 185 286 +101
Lines 32895 39670 +6775
==========================================
+ Hits 20399 22995 +2596
- Misses 11355 15338 +3983
- Partials 1141 1337 +196 ☔ View full report in Codecov by Sentry. |
iwahbe
approved these changes
Nov 15, 2023
| return r | ||
| } | ||
| panic(fmt.Errorf("List-nested block has a ListTypeable type that does not implement "+ | ||
| "TypeWithElementType: %v", s.block.Type())) | ||
| contract.Assertf(false, "List-nested block has a ListTypeable type that does not implement "+ |
There was a problem hiding this comment.
I believe we have contract.Failef
Suggested change
| contract.Assertf(false, "List-nested block has a ListTypeable type that does not implement "+ | |
| contract.Failf("List-nested block has a ListTypeable type that does not implement "+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on a recent PR feedback to use contract.Assertf instead of panic in tfgen block schema recognition.