Use single envvar to specify test org (PULUMI_TEST_OWNER)
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently two envvars that are used to specify an Pulumi Service org for tests: 1. The automation API tests look for the `PULUMI_TEST_ORG` envvar and fallback to using the `pulumi-test` org when the envvar isn't set. We're not currently setting `PULUMI_TEST_ORG` in the GHA workflows like we do in `pulumi/pulumi`, so presumably the automation API tests are using the `pulumi-test` org fallback. 2. There's also a `PULUMI_TEST_OWNER` envvar that some of the integration tests uses. We are currently setting `PULUMI_TEST_OWNER` to `moolumi`. This change updates the automation API tests to first look for the `PULUMI_TEST_OWNER` envvar, falling back to `PULUMI_TEST_ORG`, and then finally `pulumi-test`. That way, we only need to have a single consistent envvar set in CI (`PULUMI_TEST_OWNER`), set to `moolumi`, which is the org we want to use for these tests. `PULUMI_TEST_OWNER` was chosen over `PULUMI_TEST_ORG` because `PULUMI_TEST_OWNER` is also used in the Go integration test framework.
justinvp
added
the
impact/no-changelog-required
Do we consistently use the "owner" terminology for orgs everywhere else? I'd think trying to get everything consistently using "PULUMI_TEST_ORG" would be more understandable? |
Frassle
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently two envvars that are used to specify an Pulumi Service org for tests:
PULUMI_TEST_ORGenvvar and fallback to using thepulumi-testorg when the envvar isn't set. We're not currently settingPULUMI_TEST_ORGin the GHA workflows like we do inpulumi/pulumi, so presumably the automation API tests are using thepulumi-testorg fallback.PULUMI_TEST_OWNERenvvar that some of the integration tests uses. We are currently settingPULUMI_TEST_OWNERtomoolumi.This change updates the automation API tests to first look for the
PULUMI_TEST_OWNERenvvar, falling back toPULUMI_TEST_ORG, and then finallypulumi-test. That way, we only need to have a single consistent envvar set in CI (PULUMI_TEST_OWNER), set tomoolumi, which is the org we want to use for these tests.PULUMI_TEST_OWNERwas chosen overPULUMI_TEST_ORGbecausePULUMI_TEST_OWNERis also used in the Go integration test framework.