Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream v5.48.0 #3898

Merged
merged 6 commits into from
May 8, 2024
Merged

Upstream v5.48.0 #3898

merged 6 commits into from
May 8, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented May 6, 2024

Upgrades upstream to v5.48.0

Fixes #3890

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 •
edited
Loading

Does the PR have any schema changes?

Found 2 breaking changes:

Resources

  • 🟢 "aws:fsx/ontapFileSystem:OntapFileSystem": required inputs: "storageCapacity" input has changed to Required

Types

  • 🟡 "aws:bcmdata/ExportTimeouts:ExportTimeouts": properties: "delete" missing

New resources:

  • bedrock/agentAgentKnowledgeBaseAssociation.AgentAgentKnowledgeBaseAssociation

Maintainer note: consult the runbook for dealing with any breaking changes.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Is README.md missing any configuration options?

assumeRoleWithWebIdentity not found in Configuration section
customCaBundle not found in Configuration section
defaultTags not found in Configuration section
ec2MetadataServiceEndpoint not found in Configuration section
ec2MetadataServiceEndpointMode not found in Configuration section
httpProxy not found in Configuration section
httpsProxy not found in Configuration section
ignoreTags not found in Configuration section
noProxy not found in Configuration section
retryMode not found in Configuration section
s3UsEast1RegionalEndpoint not found in Configuration section
sharedConfigFiles not found in Configuration section
skipRequestingAccountId not found in Configuration section
stsRegion not found in Configuration section
tokenBucketRateLimiterCapacity not found in Configuration section
useDualstackEndpoint not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

@t0yv0
Copy link
Member Author

t0yv0 commented May 7, 2024

Looks like the regression test is catching an actual problem. We introduced custom retry for KMS condition on lambda invocation and it has regressed because upstream is moving from Go SDK v1 to Go SDK V2:

#3234

@t0yv0
Copy link
Member Author

t0yv0 commented May 7, 2024

Fixed the patch to use AWS SDKv2 and trying this again.

@t0yv0
Copy link
Member Author

t0yv0 commented May 7, 2024

aws_bedrockagent_agent_knowledge_base_association mapping to bedrock/agentAgentKnowledgeBaseAssociation.AgentAgentKnowledgeBaseAssociation is unfortunate, perhaps can do better here.

@t0yv0
Copy link
Member Author

t0yv0 commented May 7, 2024

TestAccWebserverComp flake.

@t0yv0
Copy link
Member Author

t0yv0 commented May 8, 2024

I'm running into some difficulties with moving bedrockanalysis resources namely pulumi/pulumi-terraform-bridge#1937

Going to backlog this and take the change later.

@t0yv0 t0yv0 merged commit c351e04 into master May 8, 2024
23 checks passed
@t0yv0 t0yv0 deleted the upstream-v5.48.0 branch May 8, 2024 16:45
lumiere-bot bot added a commit to coolguy1771/home-ops that referenced this pull request May 11, 2024
@lumiere-bot
fix(deps): update @pulumi/aws to 6.34.1 (#4655)
237394a 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@pulumi/aws](https://pulumi.io)
([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies |
minor | [`6.33.1` ->
`6.34.1`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.33.1/6.34.1)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>pulumi/pulumi-aws (@&#8203;pulumi/aws)</summary>

###
[`v6.34.1`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.34.1)

[Compare
Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.34.0...v6.34.1)

##### Changelog

- [`84c9dd9`](https://togithub.com/pulumi/pulumi-aws/commit/84c9dd96)
Update GitHub Actions workflows.
([#&#8203;3920](https://togithub.com/pulumi/pulumi-aws/issues/3920))

###
[`v6.34.0`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.34.0)

[Compare
Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.33.1...v6.34.0)

##### What's Changed

- Upstream v5.48.0 by [@&#8203;t0yv0](https://togithub.com/t0yv0) in
[pulumi/pulumi-aws#3898
- Fix a panic in LaunchTemplate resource by reverting "Fix updating tags
on aws_launch_template
([#&#8203;3687](https://togithub.com/pulumi/pulumi-aws/issues/3687))" by
[@&#8203;corymhall](https://togithub.com/corymhall) in
[pulumi/pulumi-aws#3908
- Fix "Attribute must be a whole number issue
([https://github.com/pulumi/pulumi/issues/16143](https://togithub.com/pulumi/pulumi/issues/16143))
by pinning to bridge at
[`c0c5779`](https://togithub.com/pulumi/pulumi-aws/commit/c0c57794d7bbf33f84620e4532d7e097abab3248)
by [@&#8203;guineveresaenger](https://togithub.com/guineveresaenger) in
[pulumi/pulumi-aws#3909

**Full Changelog**:
pulumi/pulumi-aws@v6.33.1...v6.34.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1NC4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL21pbm9yIl19-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot added a commit to coolguy1771/home-ops that referenced this pull request May 11, 2024
@lumiere-bot
fix(deps): update @pulumi/aws to 6.34.1 (#4654)
97670b9 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@pulumi/aws](https://pulumi.io)
([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies |
minor | [`6.33.1` ->
`6.34.1`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.33.1/6.34.1)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>pulumi/pulumi-aws (@&#8203;pulumi/aws)</summary>

###
[`v6.34.1`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.34.1)

[Compare
Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.34.0...v6.34.1)

##### Changelog

- [`84c9dd9`](https://togithub.com/pulumi/pulumi-aws/commit/84c9dd96)
Update GitHub Actions workflows.
([#&#8203;3920](https://togithub.com/pulumi/pulumi-aws/issues/3920))

###
[`v6.34.0`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.34.0)

[Compare
Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.33.1...v6.34.0)

##### What's Changed

- Upstream v5.48.0 by [@&#8203;t0yv0](https://togithub.com/t0yv0) in
[pulumi/pulumi-aws#3898
- Fix a panic in LaunchTemplate resource by reverting "Fix updating tags
on aws_launch_template
([#&#8203;3687](https://togithub.com/pulumi/pulumi-aws/issues/3687))" by
[@&#8203;corymhall](https://togithub.com/corymhall) in
[pulumi/pulumi-aws#3908
- Fix "Attribute must be a whole number issue
([https://github.com/pulumi/pulumi/issues/16143](https://togithub.com/pulumi/pulumi/issues/16143))
by pinning to bridge at
[`c0c5779`](https://togithub.com/pulumi/pulumi-aws/commit/c0c57794d7bbf33f84620e4532d7e097abab3248)
by [@&#8203;guineveresaenger](https://togithub.com/guineveresaenger) in
[pulumi/pulumi-aws#3909

**Full Changelog**:
pulumi/pulumi-aws@v6.33.1...v6.34.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1NC4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL21pbm9yIl19-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corymhall corymhall corymhall approved these changes

Assignees

@t0yv0 t0yv0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-aws to v5.48.0
2 participants
@t0yv0 @corymhall