Skip to content

Add authors to blogs #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 14, 2025
Merged

Conversation

mdellweg
Copy link
Member

No description provided.

@@ -44,6 +44,8 @@ plugins:
- blog:
blog_dir: blog
blog_toc: false
# The following path is weird but needed to account for the copying around all the files.
authors_file: ../../../../docs/sections/blog/.authors.yml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path only seems to be valid for -e installations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh

@mdellweg mdellweg marked this pull request as draft March 12, 2025 08:30
@mdellweg mdellweg force-pushed the blog_authors branch 2 times, most recently from b9387b0 to 31d8578 Compare March 13, 2025 13:53
pyproject.toml Outdated
@@ -7,12 +7,13 @@ name = "pulp-docs"
version = "0.0.1"
requires-python = ">= 3.11"
Copy link
Member

@pedro-psb pedro-psb Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code uses Path.walk, which requires python>=3.12.
I think its ok to bump.

@pedro-psb
Copy link
Member

When you say you'd prefer to remove shims, you mean to completely remove the pulp-docs command and rely directly on mkdocs?
A downside from that is that we'll lost the ability to pip install and start using out-of-the-box.
I like the UX of how it works today, but I can see how this would simplify the code.

Can we first migrate to use mkdocs plugin and then work out the shim? Just by start using the plugins I believe we can already simplify some of the integration

mkdocs.yml Outdated
plugins:
- PulpDocs:
plugins:
- name: pulpcore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this section should replace the repolist.yml that currently define the docs members and general settings.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I'm slowly getting there...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the structure, we'll have to add a on_nav event handler and adapt the get_navigation to build the structure we have.
I could write that one, I remember writing a lot of little details on the navigation builder.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've been trying to understand that. Can we instead of rewiring the nav change the paths of the files we include from the plugins accordingly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the paths of the files we include from the plugins accordingly

Can you provide an example? I'm not sure if I can picture that.

Lets say we have file loaded as pulp_rpm/docs/admin/index.md.
But looking at the nav structure we have:

User Manual:
    Content:
        Pulp Rpm:
            Admin:

So we would rename it to something like user_manual/content/pulp_rpm/admin/index.md to get the nav "automatically" created ?

Anyway, renaming things will break the links. I wanna put a link redirect plugin in-place, but not along with these changes.

@mdellweg
Copy link
Member Author

I really want to make it so we call mkdocs directly. And for a transition phase add a very slim shim to call it as pulp-docs.
But yes, we can try to split this work into smaller pieces. ATM this is all a big experiment.

@mdellweg mdellweg force-pushed the blog_authors branch 7 times, most recently from 509f6b7 to c7b1f45 Compare March 20, 2025 08:54
@mdellweg mdellweg force-pushed the blog_authors branch 2 times, most recently from 33ff50a to 92f957b Compare March 25, 2025 11:14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, the template. Noice

@mdellweg mdellweg force-pushed the blog_authors branch 10 times, most recently from 679a9d1 to cb7e71f Compare March 31, 2025 10:53
@mdellweg mdellweg force-pushed the blog_authors branch 4 times, most recently from a24c558 to 65b0a9b Compare March 31, 2025 11:30
@mdellweg mdellweg changed the base branch from main to rewrite-as-mkdocs-plugin April 2, 2025 13:49
@mdellweg mdellweg marked this pull request as ready for review April 14, 2025 08:22
@pedro-psb
Copy link
Member

image
❤️

@pedro-psb pedro-psb merged commit 446ab2d into pulp:rewrite-as-mkdocs-plugin Apr 14, 2025
3 checks passed
@mdellweg mdellweg deleted the blog_authors branch April 15, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants