Skip to content

WIP: Add a simpler version of the driver compatible with Verilator 5.020 #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thommythomaso
Copy link

@thommythomaso thommythomaso commented Jul 5, 2024

TODO:

@thommythomaso thommythomaso added the enhancement New feature or request label Jul 5, 2024
@thommythomaso thommythomaso self-assigned this Jul 5, 2024
@bluewww
Copy link
Collaborator

bluewww commented Jul 8, 2024

As from our previous discussion I like and support the idea. Let me know if you need directions.

@thommythomaso
Copy link
Author

As from our previous discussion I like and support the idea. Let me know if you need directions.

Thank you. From a functional perspective, the PR is ready to be reviewed. However, we do not have a solution for backward compatibility yet.

Our idea was to wrap the module-based driver in the more complex class-based driver. After checking the spec (I should have checked before - sorry), it is clear that modules cannot be instantiated within classes. Long story short, we do not yet have a solution to ensure backward compatibility without code duplication.

@paulsc96
Copy link
Member

Our idea was to wrap the module-based driver in the more complex class-based driver. After checking the spec (I should have checked before - sorry), it is clear that modules cannot be instantiated within classes.

This may be a more extreme measure, but what if we just replace jtag_test and create a new pre-release version?

As we discussed before, there is no good reason for a non-parametric interface to require virtual interfaces and classes for verification.

Nobody using proper versioning practices should experience any regressions from this change, and updating testbench code to the new module approach is very straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants