Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting an extra cas ticket that we could theoretically pass along to mediaflux #875

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

carolyncole
Copy link
Member

@carolyncole carolyncole commented Aug 1, 2024

refs #868

Adds another call to cas and a link

Screenshot 2024-08-02 at 8 11 16 AM

Copy link
Contributor

@JaymeeH JaymeeH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks @carolyncole

Comment on lines +9 to +16
mediaflux_passthru_path
# "/users/#{@user.id}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment

Comment on lines 9 to 11
msg = "This is the URL that we could pass throug to mediaflux for them to validate the user who is logged in"
msg += "It is only valid for 5 seconds "
msg += view_context.link_to("ticket validation", session[:cas_validation_url] + ticket)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is easy to follow along with

Comment on lines +27 to +28
session[:cas_login_url] = strategy.login_url(service_url)
session[:cas_validation_url] = strategy.service_validate_url(service_url, "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿

Comment on lines +42 to +44
get "mediaflux_extra", to: "users/mediaflux_callbacks#cas", as: :mediaflux_extra
get "mediaflux_passthru", to: "users/mediaflux_callbacks#passthru", as: :mediaflux_passthru
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿

@coveralls
Copy link

coveralls commented Oct 31, 2024

Coverage Status

coverage: 83.794% (-0.5%) from 84.27%
when pulling e76c374 on extra-cas-ticket
into 8a93b6b on main.

@hectorcorrea
Copy link
Member

hectorcorrea commented Nov 1, 2024

@carolyncole FYI -- I updated your branch with the updated user list that Matt posted on #1020 to include Jason Lohrey (from Arcitecta) and deployed this new version to staging.

Jason is now a valid user in staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants