Adding Schema.org tags for better discovery #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
bess
requested changes
Sep 23, 2024
There was a problem hiding this comment.
This looks great! I have a couple of requests, though:
- Can we please get an automated test for this?
- I'm posting this to the digital_open_data_and_research channel to request feedback on some of the field values, particularly "Organization." I would think we want that to be "Princeton University", but let's ask.
Fixed encoding of new lines in author helper Co-authored-by: Claudia Lee <[email protected]>
|
Hi @bess! Added automated tests and changed the organization to "Princeton University" This is what the schema tag looks like -- Let me know if there are any other changes you would like to see |
| "identifier": "<%= @document.doi_url %>", | ||
| "name": "<%= @document.title %>", | ||
| "author": <%= authors_helper(@document.authors_ordered) %>, | ||
| "version": "1", |
There was a problem hiding this comment.
Hard-coded to 1 for, but will get a real value once this has been implemented: #694
| "name": "Princeton University" | ||
| } | ||
| } | ||
| </script> |
There was a problem hiding this comment.
There is also an additional ticket to add dates once we index them (see #695)
bess
approved these changes
Oct 23, 2024
bess
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #353